Refactor SingleOwnerPlugin dependency management #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor `SingleOwnerPlugin.sol` to use `IPluginManager` interface and `UUPSUpgradeable` for plugin management, enhancing upgradeability and contract modularity. - Update execution selectors in `installPlugin` and `uninstallPlugin` methods to align with new interface.
adam-alchemy
approved these changes
Nov 28, 2023
Contributor
adam-alchemy
left a comment
adam-alchemy
left a comment
There was a problem hiding this comment.
Looks good, thank you for refactoring this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refactored
SingleOwnerPluginto useIPluginManagerandUUPSUpgradeableinstead ofUpgradeableModularAccount. This change aims to improve the plugin's generality.Also it is possible to use SingleOwnerPlugin from any ERC6900 contract.
Solution
Updated imports and adjusted execution selectors in the plugin's manifest to align with the more abstract interfaces of
IPluginManagerandUUPSUpgradeable.