Skip to content

[#5764] 신규 판단, 값블록 구현 #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 24, 2023
Merged

[#5764] 신규 판단, 값블록 구현 #2463

merged 9 commits into from
Mar 24, 2023

Conversation

@Tnks2U
Copy link
Collaborator

@Tnks2U Tnks2U commented Mar 17, 2023

@Tnks2U Tnks2U requested review from kimorkim, leunge and prisml March 17, 2023 08:31
@Tnks2U Tnks2U self-assigned this Mar 17, 2023
@github-actions github-actions bot added the issue 내부 이슈 처리를 위한 PR label Mar 17, 2023
github-actions[bot]
github-actions bot reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

src/playground/blocks/block_calc.js|1103 col 33| Unexpected space before function parentheses.
src/playground/blocks/block_calc.js|1110 col 33| Delete ·
src/playground/blocks/block_calc.js|1110 col 33| Unexpected space before function parentheses.
src/playground/blocks/block_calc.js|1172 col 33| Delete ·
src/playground/blocks/block_calc.js|1172 col 33| Unexpected space before function parentheses.
src/playground/blocks/block_calc.js|1179 col 33| Delete ·
src/playground/blocks/block_calc.js|1179 col 33| Unexpected space before function parentheses.
src/playground/blocks/block_calc.js|1310 col 33| Delete ·
src/playground/blocks/block_calc.js|1310 col 33| Unexpected space before function parentheses.
src/playground/blocks/block_calc.js|1317 col 33| Delete ·
src/playground/blocks/block_calc.js|1317 col 33| Unexpected space before function parentheses.
src/playground/blocks/block_calc.js|1525 col 29| Insert ····
src/playground/blocks/block_calc.js|1531 col 1| Replace ···························· with ································
src/playground/blocks/block_calc.js|1784 col 50| Replace .split('').reverse() with ⏎························.split('')⏎························.reverse()⏎························
src/playground/blocks/block_calc.js|2460 col 1| Insert ····
src/playground/blocks/block_judgement.js|277 col 35| Replace ⏎····························[Lang.Blocks.is_type_number,·'number'],⏎························ with [Lang.Blocks.is_type_number,·'number']

src/class/engine.js Outdated
_addEventListener('entityClick', (entity) => {
const objId = entity.id;
Entry.stage.clickedObjectId = objId;
this.fireEventOnEntity('when_object_click', entity)
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.

Suggested change
this.fireEventOnEntity('when_object_click', entity)
this.fireEventOnEntity('when_object_click', entity);

src/class/engine.js Outdated
});
_addEventListener('entityClickCanceled', (entity) => {
delete Entry.stage.clickedObjectId;
this.fireEventOnEntity('when_object_click_canceled', entity)
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.

Suggested change
this.fireEventOnEntity('when_object_click_canceled', entity)
this.fireEventOnEntity('when_object_click_canceled', entity);

src/class/engine.js Outdated
)
.appendTo(this.view_)
.bindOnClick(function(e) {
.bindOnClick(function (e) {
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·

Suggested change
.bindOnClick(function (e) {
.bindOnClick(function(e) {

src/class/engine.js Outdated
)
.appendTo(this.view_)
.bindOnClick(function(e) {
.bindOnClick(function (e) {
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Suggested change
.bindOnClick(function (e) {
.bindOnClick(function(e) {

src/class/engine.js Outdated
)
.appendTo(this.view_)
.bindOnClick(function(e) {
.bindOnClick(function (e) {
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·

Suggested change
.bindOnClick(function (e) {
.bindOnClick(function(e) {

src/class/engine.js Outdated
Entry.dispatchEvent('stop');
Entry.stage.hideInputField();
(function(w) {
(function (w) {
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·

Suggested change
(function (w) {
(function(w) {

src/class/engine.js Outdated
Entry.dispatchEvent('stop');
Entry.stage.hideInputField();
(function(w) {
(function (w) {
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Suggested change
(function (w) {
(function(w) {

src/class/engine.js Outdated
const index = this.execPromises.length;
promises.forEach((promise, i) => {
const execPromise = (async function() {
const execPromise = (async function () {
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·

Suggested change
const execPromise = (async function () {
const execPromise = (async function() {

src/class/engine.js Outdated
const index = this.execPromises.length;
promises.forEach((promise, i) => {
const execPromise = (async function() {
const execPromise = (async function () {
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Suggested change
const execPromise = (async function () {
const execPromise = (async function() {

src/playground/blocks/block_calc.js
events: {
viewAdd: [
function() {
function () {
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·

Suggested change
function () {
function() {

github-actions[bot]
github-actions bot reviewed Mar 17, 2023
View reviewed changes
src/playground/blocks/block_calc.js
events: {
viewAdd: [
function() {
function () {
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Suggested change
function () {
function() {

src/playground/blocks/block_calc.js
],
viewDestroy: [
function(block, notIncludeSelf) {
function (block, notIncludeSelf) {
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·

Suggested change
function (block, notIncludeSelf) {
function(block, notIncludeSelf) {

src/playground/blocks/block_calc.js
],
viewDestroy: [
function(block, notIncludeSelf) {
function (block, notIncludeSelf) {
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Suggested change
function (block, notIncludeSelf) {
function(block, notIncludeSelf) {

src/playground/blocks/block_calc.js
],
dataDestroy: [
function(block) {
function (block) {
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·

Suggested change
function (block) {
function(block) {

src/playground/blocks/block_calc.js
],
dataDestroy: [
function(block) {
function (block) {
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Suggested change
function (block) {
function(block) {

src/playground/blocks/block_calc.js
return Math.sqrt(
Math.pow(sprite.getX() - mousePos.x, 2) +
Math.pow(sprite.getY() - mousePos.y, 2)
Math.pow(sprite.getY() - mousePos.y, 2)
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ···························· with ································

Suggested change
Math.pow(sprite.getY() - mousePos.y, 2)
Math.pow(sprite.getY() - mousePos.y, 2)

src/playground/blocks/block_calc.js
return Math.sqrt(
Math.pow(sprite.getX() - targetEntity.getX(), 2) +
Math.pow(sprite.getY() - targetEntity.getY(), 2)
Math.pow(sprite.getY() - targetEntity.getY(), 2)
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ···························· with ································

Suggested change
Math.pow(sprite.getY() - targetEntity.getY(), 2)
Math.pow(sprite.getY() - targetEntity.getY(), 2)

src/playground/blocks/block_calc.js
isNotFor: [],
func(sprite, script) {
const originStr = script.getStringValue('STRING', script);
const reversedStr = originStr.split('').reverse().join('');
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace .split('').reverse() with ⏎························.split('')⏎························.reverse()⏎························

Suggested change
const reversedStr = originStr.split('').reverse().join('');
const reversedStr = originStr
.split('')
.reverse()
.join('');

src/playground/blocks/block_calc.js
return script
.getStringValue('STRING', script)
[script.getField('CASE', script)]();
[script.getField('CASE', script)]();
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····

Suggested change
[script.getField('CASE', script)]();
[script.getField('CASE', script)]();

src/playground/blocks/block_judgement.js
Comment on lines +277 to +279
options: [
[Lang.Blocks.is_type_number, 'number'],
],
Copy link
Contributor

@github-actions github-actions bot Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····························[Lang.Blocks.is_type_number,·'number'],⏎························ with [Lang.Blocks.is_type_number,·'number']

Suggested change
options: [
[Lang.Blocks.is_type_number, 'number'],
],
options: [[Lang.Blocks.is_type_number, 'number']],

@leunge leunge merged commit 82f0d5e into develop Mar 24, 2023
@leunge leunge deleted the issue/5764 branch March 24, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@leunge leunge leunge approved these changes

@kimorkim kimorkim Awaiting requested review from kimorkim

@prisml prisml Awaiting requested review from prisml

Assignees

@Tnks2U Tnks2U

Labels

issue 내부 이슈 처리를 위한 PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tnks2U @leunge