[4.21.0] 하드웨어 1.9.38 PR #2434
Merged
[4.21.0] 하드웨어 1.9.38 PR #2434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Tnks2U
commented
Jan 20, 2023
Tnks2U
commented
- https://oss.navercorp.com/entry/entry2/issues/5698
develop-hw 최신화
Issue/microbit eventblock
feat: 웹연결 버튼 조건 변경
This reverts commit acb5c24.
- 버튼 중복입력을 방지하기 위해 쓰로틀링 추가
Change the icobot_get_discomfort_index_value
[#5643] 마이크로비트 버튼이벤트 추가
feat: 버튼이벤트 블록 위치 수정
develop-hw 최신화
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // INFO: 디바이스가 모바일이거나 일렉트론이면 1차적으로 제외 | ||
| if (userAgentString.includes('mobile') || userAgentString.includes('electron')) { | ||
| return false; | ||
| } else if (userAgentString.includes('whale') || userAgentString.includes('edge') || userAgentString.includes('chrome')) { |
Contributor
| // INFO: 디바이스가 모바일이거나 일렉트론이면 1차적으로 제외 | ||
| if (userAgentString.includes('mobile') || userAgentString.includes('electron')) { | ||
| return false; | ||
| } else if (userAgentString.includes('whale') || userAgentString.includes('edge') || userAgentString.includes('chrome')) { |
Contributor
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace userAgentString.includes('whale')·||·userAgentString.includes('edge')·||·userAgentString.includes('chrome') with ⏎············userAgentString.includes('whale')·||⏎············userAgentString.includes('edge')·||⏎············userAgentString.includes('chrome')⏎········
Suggested change
| } else if (userAgentString.includes('whale') || userAgentString.includes('edge') || userAgentString.includes('chrome')) { | |
| } else if ( | |
| userAgentString.includes('whale') || | |
| userAgentString.includes('edge') || | |
| userAgentString.includes('chrome') | |
| ) { |
kimorkim
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.