Skip to content

Update usage of open() in setup.py #9661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2025
Merged

Update usage of open() in setup.py #9661

merged 1 commit into from
Mar 6, 2025

Conversation

mikemanger
Copy link
Contributor

This PR removes a Python 2 compatible import and redundant read mode for the open() function from setup.py.

lovelydinosaur
lovelydinosaur approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@lovelydinosaur lovelydinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I'm trying to dial down almost all churn against this codebase.... this is obviously reasonable, and slightly neater. 😊

(thanks)

@lovelydinosaur lovelydinosaur merged commit 1e8ac7c into encode:master Mar 6, 2025
8 checks passed
@mikemanger mikemanger deleted the update-setup branch March 8, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovelydinosaur lovelydinosaur lovelydinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikemanger @lovelydinosaur