Clean up of Url / Path #7325
Closed
Clean up of Url / Path #7325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
nice work ! |
lovelydinosaur
requested changes
May 15, 2020
Contributor
lovelydinosaur
left a comment
lovelydinosaur
left a comment
There was a problem hiding this comment.
Just waiting on https://github.com/encode/django-rest-framework/pull/7325/files#r423571865 for this one
tests/test_urlpatterns.py
Outdated
Comment on lines
175
to
177
| url('^url/(?P<child>[0-9]+)$', dummy_view) | ||
| path('url/<int:child>', dummy_view) | ||
| ] | ||
| urlpatterns = [ | ||
| url('^purl/(?P<parent>[0-9]+)/', include(nested_patterns), {'foo': 'bar'}), | ||
| path('purl/<int:parent>/', include(nested_patterns), {'foo': 'bar'}), |
Contributor
There was a problem hiding this comment.
@auvipy not sure if you had a chance to revert these changes, but this is the only thing blocking your PR from passing 🙂 .
There is a reason why there are two URL patterns in each of the lists, and they should not be the same thing 2x. The url one is testing that it leaves the arguments as strings, and the path one should parse integers and why the test is failing.
Collaborator
Author
There was a problem hiding this comment.
gonna revert this soon
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.