Docs sidebar improvements (#5638) #6589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Joachim Jablon <[email protected]>
Co-Authored-By: Joachim Jablon <[email protected]>
Author
|
Before/after screenshots: |
Contributor
|
Great work. That looks much nicer. Adding to the 3.10 milestone for review. |
Contributor
|
Great stuff, thanks! |
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
* add sans-serif fallback for Verdana in docs sidebar Co-Authored-By: Joachim Jablon <[email protected]> * improve display for docs sidebar (encode#5638) Co-Authored-By: Joachim Jablon <[email protected]>
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
* add sans-serif fallback for Verdana in docs sidebar Co-Authored-By: Joachim Jablon <[email protected]> * improve display for docs sidebar (encode#5638) Co-Authored-By: Joachim Jablon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tackles #5638, with a different approach: make the sidebar look good with the default size even if the endpoints names are long.
We could make it resizable if still needed.
Also contains a fallback font when Verdana is missing (
sans-serif).Done in pair with @ewjoachim
We also thought about other ideas to improve the sidebar but @tomchristie said there is going to be change with API star.