Update quickstart to Django 2.0 routing syntax #6385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@chrisshyi In your PR, you removed all of the Edit: The Django tutorial doesn't use
|
This is what is prescribed in the Django 2.1 tutorial
Contributor
|
I believe the raw string identifiers were not needed in new |
Contributor
Author
|
Thanks @chrisshyi. I've removed them in the latest commits. |
Contributor
|
Yup, looks good. |
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
* Update quickstart to Django 2.0 routing syntax * Remove uneccessary raw string identifiers * Correctly import path function * Fix import path to use django.urls This is what is prescribed in the Django 2.1 tutorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a new user to DRF, I was confused when I did the Django tutorial (which uses
path) and then tried out the DRF quickstart and saw that it still used the older (probably soon to be deprecated)urlrouting. I think this will help alleviate some confusion for new users.I believe this was overlooked in #5964.
Related to #5963.
cc @chrisshyi