Skip to content

Conversation

@lovelydinosaur
Copy link
Contributor

Closes #2180.

Filters rendering in the browsable API and admin.

Remaining:

  • Docs.
  • Use translated strings throughout.
  • Render bootstrap forms directly, dropping the crispy forms optional req.
  • Consider search control rendering directly? (But could be a second pass)

This sort of thing...

image


image

@jpadilla
Copy link
Contributor

@tomchristie looking great, any specific reason for introducing the requirement for crispy forms?

@lovelydinosaur
Copy link
Contributor Author

@jpadilla django-filters won't render nicely with our bootstrap style out-of-the-box.

We'd probably be making it a soft requirement, but there's also a poss of moving DjangoFilterBackend into a third party package, and then including a built-in field filtering class that uses serializers (since they actually have everything we'd need to make this work).

@carltongibson
Copy link
Collaborator

there's also a poss of moving DjangoFilterBackend into a third party package

I'd be happy to maintain such a package.

I have a slight niggle about re-creating functionality that already exists; the prejudice is to consolidate effort rather than split it...

@lovelydinosaur
Copy link
Contributor Author

I'd be happy to maintain such a package.

That would be pretty amazing. Ideally I'd like to see us do that with both django-filter and django-guardian so that external deps are only required in external packages.

@carltongibson
Copy link
Collaborator

OK. Fine. I'll put something together.

lovelydinosaur added a commit that referenced this pull request Oct 22, 2015
First pass at HTML rendering for filters
@lovelydinosaur lovelydinosaur merged commit c53c9ed into master Oct 22, 2015
@lovelydinosaur lovelydinosaur deleted the filters branch October 22, 2015 10:42
@lovelydinosaur lovelydinosaur changed the title First pass at HTML rendering for filters HTML rendering for filters Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants