Suggestion for the IsAdminUser permission class naming

[hkage]

Hello,

I am not sure whether this is worth an issue, but the permission class IsAdminUser currently checks for the is_staff flag (changed in #88). The name of the permission class suggests, that the user needs to have the is_superuser flag. Maybe the name IsStaffUser would be a better choice and an additional IsAdminUser class would check for the is_superuser flag instead, just to clarify the naming of the permission class.

With kind regards,
Henning

[lovelydinosaur]

Perfectly reasonable suggestion, yup.
I think the current naming falls into the 'good enough' category to not justify changing it. I might reconsider with the 3.0 release, but my inclination at the moment would be to leave things as-is, in order to minize the awkwardness of changing this. (Especially wouldn't be keen on renaming, but the re-introducing an IsAdminUser with different behavior, as that'd be an easy reciepe for really screwing with users who'd not read the release notes on a new version.

[hkage]

Alright, thanks for your explanation, that makes sense.