Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Oct 18, 2019

These are part of releases-fastcomp but for some reason are not
included in the upstream equivalent. I imagine they were simply
overlooked.

These are part of `releases-fastcomp` but for some reason are not
included in the upstream equivalent.  I imagine they were simply
overlooked.
@sbc100 sbc100 requested review from dschuff and kripken October 18, 2019 01:02
@kripken
Copy link
Member

kripken commented Oct 18, 2019

Hmm, I think this makes sense, however, in the current model this means we'll re-download python and java on each version update. We also do that for node, so this would be tripling or more that wasted overhead.

Maybe we can fix that re-download issue before landing this (or soon after, if this is urgent)? I think we may want to add an option to manifest entries to say "keep the zip around, and if it's around, don't re-download", which we'd use for node, python, java, but not for the waterfall builds (where we want to delete the archive after download, to avoid them accumulating over time).

@sbc100
Copy link
Collaborator Author

sbc100 commented Oct 18, 2019

Yes, this change just bring upsteam in line with fastcomp. I think we should land this now.

As for caching tar files around, I think we should go back to doing that yes. We can find some say the clean them up over time. Perhaps just keep the last N, by filesytem date? That's a separate issue though.

@sbc100
Copy link
Collaborator Author

sbc100 commented Oct 18, 2019

Can we land this before #373 ?

@sbc100 sbc100 merged commit e047fe4 into master Oct 18, 2019
@sbc100 sbc100 deleted the add_windows_deps branch October 18, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants