Use configurable properties in our assertion checks #9360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… amount of work would let the user override these at runtime. For example, we set a readBinary property to guard against incorrect usages of that changed API, but in binaryen there happens to be an added export by that name - so in ASSERTIONS builds we hit an error. With this change, projects still get the assertion check, but they can delete the property manually, then set it, as a workaround.
…table: true }); Module.readBinary = ..
kripken
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Aug 30, 2019
kripken
changed the title
kripken
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Aug 30, 2019
jgravelle-google
approved these changes
Sep 19, 2019
kripken
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Dec 6, 2019
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…9360) Without this, no amount of work would let the user override these at runtime. For example, we set a readBinary property to guard against incorrect usages of that changed API, but in binaryen there happens to be an added export by that name - so in ASSERTIONS builds we hit an error. With this change, projects still get the assertion check, but they can overwrite the property manually, then set it, as a workaround, with something like this: Object.defineProperty(Module, 'readBinary', { writable: true }); Module.readBinary = ..new value..;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, no amount of work would let the user override these at runtime. For example, we set a readBinary property to guard against incorrect usages of that changed API, but in binaryen there happens to be an added export by that name - so in ASSERTIONS builds we hit an error.
With this change, projects still get the assertion check, but they can overwrite the property manually, then set it, as a workaround, with something like this: