Improve and document the issue with test_stack_varargs* #7951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out why these fail sometimes - in node.js, we set
argv[0]to the native program being run. We allocate that on the stack (I guess to avoid a malloc). And so the filename of the program being run influences how much stack we use. As a result, if a random temp dir is used with a particularly long name, we can error in tests that check for not exceeding a minimal amount of stack usage.Amusingly, in particular this explains why I couldn't see it locally, where I run with
EMTEST_SAVE_DIR- that makes it use a standard (short) test dir name, not a random one which might be long...I doubled the amount of stack we allow in those tests (they check that loops don't increase stack space unboundedly), which should make them ok even with a path name of a few K now, and documented it to avoid future confusion should they fail again.