Skip to content

Skip other.test_pthread_growth test on Windows on ARM #25628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

Skip other.test_pthread_growth test on Windows on ARM #25628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import json
import locale
import os
import platform
import random
import re
import select
Expand Down Expand Up @@ -12987,6 +12988,11 @@ def test_growable_arraybuffers(self):
'minimal': (['-sMINIMAL_RUNTIME', '-sMODULARIZE', '-sEXPORT_NAME=MyModule'],),
})
def test_pthread_growth(self, cflags, pthread_pool_size = 1):
if WINDOWS and platform.machine() == 'ARM64':
# https://github.com/emscripten-core/emscripten/issues/25627
# TODO: Switch this to a "require Node.js 24" check
self.require_node_canary()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go in the else block below because the if branch already requires node canary.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm how do you mean the if branch already requires node canary?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean line 13000 below.

Since the GROWABLE_ARRAYBUFFERS already requires canary, and the comment here belngs instead in the else branch below.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.. I think it probably reads cleaner to not intertwine this test skip/workaround with the growable arraybuffer logic part.


self.set_setting('PTHREAD_POOL_SIZE', pthread_pool_size)
if '-sGROWABLE_ARRAYBUFFERS' in cflags:
self.node_args.append('--experimental-wasm-rab-integration')
Expand Down