Fix wasmfs.test_fs_nodefs_readdir on Windows. #25039
Conversation
| @@ -5868,7 +5868,7 @@ def test_fs_nodefs_readdir(self): | |||
| self.cflags += ['-lnodefs.js'] | |||
| suffix = '' | |||
| if self.get_setting('WASMFS'): | |||
| suffix = '.wasmfs' | |||
| suffix = '.wasmfs_win' if WINDOWS else '.wasmfs' | |||
There was a problem hiding this comment.
IIUC the issue here is the order in which directories are listed?
I wonder if we can instead have either:
- Have wasmfs list directories in a deterministic / alphabetical order
- Update the test to avoid depending on specific ordering.
Adding another separate copy of the expectations seems less desirable.
There was a problem hiding this comment.
This is not an ordering problem, but a problem that Windows does not support FIFO objects on the filesystem, so the test is unable to add one. And hence fails to readdir() it in the filesystem on Windows.
There was a problem hiding this comment.
Perhaps add a comment as to why these three different output are needed?
juj
force-pushed
the
fix_wasmfs_test_fs_nodefs_readdir_windows
branch
from
02feecb to
99173ae
Compare
|
Ping, any further thoughts here? |
|
In general, I don't love the solution of having get more different output expectation file, since it makes it hard to see how/why the different configs have different output. But I don't see any other great options here. |
Windows does not support fifos, so the test expectation needs to look different.