Fix specifying the dependency from SYSCALL_DEBUG to $strError() function. #25032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion to take place directly where the use of strError() is emitted, and not indirectly via the JS SYSCALLS object. Fixes WASMFS + SYSCALLS_DEBUG build mode, e.g. in test wasmfs.test_fs_nodefs_rw.
juj
force-pushed
the
fix_syscall_debug_deps
branch
from
151d1c9 to
3de5206
Compare
sbc100
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix specifying the dependency from SYSCALL_DEBUG to $strError() function to take place directly where the use of strError() is emitted, and not indirectly via the JS SYSCALLS object. Fixes WASMFS + SYSCALLS_DEBUG build mode, e.g. in test wasmfs.test_fs_nodefs_rw.