Split up test other.test_standalone_system_headers to parallelize test runtime. #25019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Aug 25, 2025
test/test_other.py
Outdated
| # Process files depending on first char of the file in different test cases for parallelization, though | ||
| # special case SDL_ prefix to parallelize better. | ||
| first_char = (header[4] if header.startswith('SDL_') else header[0]).lower() | ||
| if first_char not in prefix or (prefix == '*' and ord(first_char) >= ord('a') and ord(first_char) <= ord('z')): |
There was a problem hiding this comment.
(prefix == '*' and firstchar.isalpha())
There was a problem hiding this comment.
That wouldn't be strictly accurate, since the set of characters that return true on .isalpha() is much more than a-z. Though updated to smooth review along.
No, the test is still unfortunately slow, just not quite as slow as before. |
juj
force-pushed
the
speed_up_standalone_system_headers_test
branch
from
760b992 to
0b96861
Compare
sbc100
approved these changes
Aug 25, 2025
juj
force-pushed
the
speed_up_standalone_system_headers_test
branch
from
0b96861 to
a45ebea
Compare
…t runtime. It is still a slow test (> minute runtime), but much less than five minutes.
juj
force-pushed
the
speed_up_standalone_system_headers_test
branch
from
a45ebea to
7329186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up test other.test_standalone_system_headers to parallelize test runtime. It is still a slow test (> minute runtime), but much faster than before.
Before:
Ran 1 test in 272.024sAfter:
Total core time: 386.746s. Wallclock time: 64.692s. Parallelization: 5.98x.