Split test_emscripten_get_compiler_setting. NFC #25009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
test_emscripten_get_compiler_setting
branch
from
750d701 to
dbd6cec
Compare
kripken
approved these changes
Aug 21, 2025
sbc100
force-pushed
the
test_emscripten_get_compiler_setting
branch
from
dbd6cec to
90fa1aa
Compare
Split the test so into two so we are testing one thing in each test.
sbc100
force-pushed
the
test_emscripten_get_compiler_setting
branch
from
90fa1aa to
c9a79df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the test so into two so we are testing one thing in each test.