Fix test_prepost_run_dep after #24890 #24898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cleanup the test - Add and `id` to the `addRunDependency` call. - Add `.unref` to prevent the dependency watcher from keeping the node process alive. Prior to emscripten-core#24890 the lack of `id` in used in the test caused it to skip the dependency watcher. - Add some RUNTIME_DEBUG logging to add/removeRunDependency.
sbc100
force-pushed
the
fix_test_prepost_run_dep
branch
from
9ac23a3 to
ab13ed1
Compare
Collaborator
Author
|
Landing TBR to green the tree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idto theaddRunDependencycall..unrefto prevent the dependency watcher from keeping the node process alive. Prior to Requireidin addRunDependency/removeRunDependency #24890 the lack ofidin used in the test caused it to skip the dependency watcher.--closure=1to make sure closure doesn't minify the.unrefcall.