[EH] Add WASM_LEGACY_EXCEPTIONS option #23365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the existing `WASM_EXNREF` option with `WASM_LEGACY_EXCEPTIONS` option, in an effort to make the new standardized exnref proposal the 'default' state and the legacy proposal needs to be separately enabled an option. But given that most users haven't switched to the new proposal and major web browsers haven't turned it on by default, this `WASM_LEGACY_EXCEPTIONS` is turned on by default for the moment. This changes the following function names in `test/common.py` as well: - `require(s)_wasm_eh` -> `require(s)_wasm_legacy_eh` - `require(s)_wasm_exnref` -> `require(s)_wasm_eh` The test names and suffixes will be changed in a follow-up.
dschuff
reviewed
Jan 10, 2025
| self.skipTest('Wasm EH does not work with asan yet') | ||
| self.emcc_args.append('-fwasm-exceptions') | ||
| self.set_setting('SUPPORT_LONGJMP', 'wasm') | ||
| if mode == 'wasm': |
Member
There was a problem hiding this comment.
Should we also change the mode names to something like 'legacy' and 'exnref'?
Member
Author
There was a problem hiding this comment.
Yeah test suffixes / mode names will be changed too in a followup.
dschuff
approved these changes
Jan 10, 2025
Member
dschuff
left a comment
dschuff
left a comment
There was a problem hiding this comment.
Looks good, now is definitely the time to change this, before we really have any users.
Member
Author
|
Should we add this to Emscripten 4.0.0 release? It's a new option to let the users to use the new exnref EH proposal so it might be a good idea... I realized we haven't announced the previous option |
sbc100
approved these changes
Jan 10, 2025
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Yup lets get this into 4.0
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the existing
WASM_EXNREFoption withWASM_LEGACY_EXCEPTIONSoption, in an effort to make the new standardized exnref proposal the 'default' state and the legacy proposal needs to be separately enabled an option. But given that most users haven't switched to the new proposal and major web browsers haven't turned it on by default, thisWASM_LEGACY_EXCEPTIONSis turned on by default for the moment.This changes the following function names in
test/common.pyas well:require(s)_wasm_eh->require(s)_wasm_legacy_ehrequire(s)_wasm_exnref->require(s)_wasm_ehEven if
WASM_LEGACY_EXCEPTIONSdefaults to true for now, this addsset_setting(WASM_LEGACY_EXCEPTIONS)in the tests to minimize future fixes whenWASM_LEGACY_EXCEPTIONSwill eventually be turned off by default.The test names and suffixes will be changed accordingly in a follow-up.
This is in line with llvm/llvm-project#122158.