Use llrintf over llrint in SSE funcs. NFC #22894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Nov 11, 2024
system/include/compat/emmintrin.h
Outdated
| // TODO: optimize | ||
| if (isnan(__a[0]) || isinf(__a[0])) return 0x8000000000000000LL; | ||
| long long x = llrint(__a[0]); | ||
| long long x = llrintf(__a[0]); |
Member
There was a problem hiding this comment.
But __m128d is f64x2, so operating on doubles should be more correct.
Collaborator
Author
There was a problem hiding this comment.
Do is the fabsf on the line below wrong in this case then?
Collaborator
Author
There was a problem hiding this comment.
Updated the line below instead.
tlively
approved these changes
Nov 11, 2024
These function operate of floats so this is slighlyt more correct and perhaps faster in some cases I guess.
uysalibov
pushed a commit
to uysalibov/emscripten
that referenced
this pull request
Nov 15, 2024
These function operate of floats so this is slighlyt more correct and perhaps faster in some cases I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These function operate of floats so this is slighlyt more correct and perhaps faster in some cases I guess.