Use @wraps on all test decorators
#22377
Merged
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleisauke
approved these changes
Aug 14, 2024
Collaborator
kleisauke
left a comment
kleisauke
left a comment
There was a problem hiding this comment.
Great! It looks like this was indeed the reason why test_module_stdin_rawfs and test_module_stdout_stderr_rawfs weren't executed on the Windows CircleCI runner.
https://circleci.com/gh/emscripten-core/emscripten/806908
Without this the decorated function doesn't mirror properties of the underlying tests, which was breaking things like `@crossplatform`. See emscripten-core#18163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this the decorated function doesn't mirror properties of the underlying tests, which was breaking things like
@crossplatform.See #18163