Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Apr 5, 2024

No description provided.

@sbc100 sbc100 requested review from juj and kripken April 5, 2024 19:46
@sbc100
Copy link
Collaborator Author

sbc100 commented Apr 5, 2024

While working a major change to our pthread code (#21701) I realized we didn't yet have any coverage to pthreads + MINIMAL_RUNTIME under node.

@sbc100 sbc100 force-pushed the minimal_runtime_node_pthreads branch 2 times, most recently from 4fac60b to ce7a63d Compare April 5, 2024 19:58
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % question

@sbc100 sbc100 force-pushed the minimal_runtime_node_pthreads branch 3 times, most recently from ac26d1d to 3be56a0 Compare April 5, 2024 21:40
@sbc100 sbc100 requested a review from kripken April 5, 2024 22:16
@sbc100 sbc100 force-pushed the minimal_runtime_node_pthreads branch 2 times, most recently from 2ce5ed4 to 1fb4924 Compare April 5, 2024 22:25
@sbc100 sbc100 enabled auto-merge (squash) April 5, 2024 23:13
@sbc100 sbc100 force-pushed the minimal_runtime_node_pthreads branch from 1fb4924 to 5fac8a4 Compare April 5, 2024 23:37
@sbc100 sbc100 force-pushed the minimal_runtime_node_pthreads branch from 5fac8a4 to 64c2aae Compare April 6, 2024 00:02
@sbc100 sbc100 merged commit 597ffc1 into emscripten-core:main Apr 6, 2024
@sbc100 sbc100 deleted the minimal_runtime_node_pthreads branch April 6, 2024 01:11
impact-maker pushed a commit to impact-maker/emscripten that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants