[EH] Don't write to readonly Exception.stack property #21065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently `WebAssembly.Exception.stack` has been `readonly` all along and I wasn't aware. While I'm not sure if this should be `readonly` and this may change in the future, for now writing to this property is not spec compliant, so this removes the routine that tidies up the stack trace, which is not the end of the world. Fixes emscripten-core#21044.
|
It is hard to add a FireFox test because, as I said in #21050 (comment), because the test fails anyway (due to a thrown exception), the only way to check if FF works is to check the error message, but SpiderMonkey doesn't emit any error message even if a non-writable property is set anyway. (Also this PR removes the property-setting routine, so it's not even clear what we should check for..) |
sbc100
approved these changes
Jan 11, 2024
kripken
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently
WebAssembly.Exception.stackhas beenreadonlyall along and I wasn't aware. While I'm not sure if this should bereadonlyand this may change in the future, for now writing to this property is not spec compliant, so this removes the routine that tidies up the stack trace, which is not the end of the world.Fixes #21044.