Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Nov 30, 2023

No description provided.

@sbc100 sbc100 requested review from dschuff and kripken November 30, 2023 23:16
@kripken
Copy link
Member

kripken commented Dec 1, 2023

@sbc100 the current browser64_4gb tests seem to fail a lot. I see this particular test fail both on main atm and in a branch of mine:

FAIL [121.084s]: test_emscripten_log (test_browser.browser64_4gb)

Is that a known issue?

@sbc100
Copy link
Collaborator Author

sbc100 commented Dec 1, 2023

@sbc100 the current browser64_4gb tests seem to fail a lot. I see this particular test fail both on main atm and in a branch of mine:

FAIL [121.084s]: test_emscripten_log (test_browser.browser64_4gb)

Is that a known issue?

Nope.. these test do use a lot of memory... so I guess that could be the cause of flake

@sbc100 sbc100 merged commit 06561ee into emscripten-core:main Dec 1, 2023
@sbc100 sbc100 deleted the browser64_4gb branch December 1, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants