Skip to content

Fix typo in transpile warning. NFC #20813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix typo in transpile warning. NFC #20813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,7 @@ jobs:
- install-emsdk
- install-node-canary
- run-tests:
title: "selected subset"
title: "node (canary)"
test_targets: "
other.test_deterministic
other.test_gen_struct_info
Expand All @@ -747,7 +747,7 @@ jobs:
- install-node-version:
node_version: "10.19.0"
- run-tests:
title: "selected subset"
title: "node (oldest / 10.19.0)"
test_targets: "
other.test_gen_struct_info
other.test_native_call_before_init
Expand All @@ -761,7 +761,7 @@ jobs:
- run-tests:
# Run tests that on older versions of node would require flags, but
# those flags should not be injected on newer versions.
title: "selected subset"
title: "node (latest)"
test_targets: "-v
other.test_gen_struct_info
other.test_native_call_before_init
Expand Down
2 changes: 1 addition & 1 deletion tools/link.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,7 +1142,7 @@ def phase_linker_setup(options, state, newargs):
settings.MIN_IE_VERSION != 0x7FFFFFFF)

if options.use_closure_compiler is None and settings.TRANSPILE_TO_ES5:
diagnostics.warning('transpile', 'enabling transpilation via closure due to browser version settings. This warning can be suppressed by passing `--closure=1` or `--closure=0` to opt into our explicitly.')
diagnostics.warning('transpile', 'enabling transpilation via closure due to browser version settings. This warning can be suppressed by passing `--closure=1` or `--closure=0` to opt into this explicitly.')

# https://caniuse.com/class: EDGE:13 FF:45 CHROME:49 SAFARI:9
supports_es6_classes = (settings.MIN_EDGE_VERSION >= 13 and
Expand Down