[wasm64] Run glbook tests under browser64. NFC #20633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Nov 7, 2023
sbc100
force-pushed
the
browser64_glbook
branch
2 times, most recently
from
f01ced0 to
be17bb3
Compare
sbc100
force-pushed
the
browser64_glbook
branch
from
be17bb3 to
6c93817
Compare
As part of this EGLNativeDisplayType was fixed to match X11 This allows `Display*` (a pointer type) to be passed into our eglGetDisplay function without a cast warning on wasm64 (where pointers and int have a different width). Split out from emscripten-core#20516
sbc100
force-pushed
the
browser64_glbook
branch
from
6c93817 to
cda0272
Compare
kripken
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #20516