[wasm64] Run all browser64 egl/gl/glfw/glew tests #20603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
egl_wasm64
branch
2 times, most recently
from
46c7c2b to
a05952b
Compare
sbc100
changed the title
sbc100
commented
Nov 2, 2023
| this.keyFunc = null; // GLFWkeyfun | ||
| this.charFunc = null; // GLFWcharfun | ||
| this.userptr = null; | ||
| this.windowPosFunc = 0; // GLFWwindowposfun |
Collaborator
Author
There was a problem hiding this comment.
This change is because null cannot be converted to BigInt when we return these as pointers.
sbc100
changed the title
sbc100
changed the title
kripken
reviewed
Nov 2, 2023
src/library_glew.js
Outdated
| extensionIsSupported(name) { | ||
| if (!GLEW.extensions) { | ||
| GLEW.extensions = UTF8ToString(_glGetString(0x1F03)).split(' '); | ||
| GLEW.extensions = GLctx.getSupportedExtensions() || []; |
Member
There was a problem hiding this comment.
This does not apply the processing that GL_EXTENSIONS_IN_PREFIXED_FORMAT does in library_webgl.js, so it changes behavior potentially?
emscripten/src/library_webgl.js
Lines 1143 to 1149 in f140f5c
Collaborator
Author
There was a problem hiding this comment.
Good catch. Fixed by adding new GL.getExtensions() helper method.
kripken
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #20516