Include proxy to worker flag #19911
Open
Include proxy to worker flag #19911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To repro issues in glfw code
sbc100
reviewed
Jul 27, 2023
test/test_browser.py
Outdated
| self.btest(test_file('browser/test_glfw3.c'), args=['-sUSE_GLFW=3', '-lglfw', '-lGL'] + args + opts, expected='1') | ||
|
|
||
| @requires_graphics_hardware | ||
| def test_glfw_events(self): |
Collaborator
There was a problem hiding this comment.
Can you use @parameterized to run the test both with and without proxy-to-worker?
By the way are you actually using -sPROXY_TO_WORKER in your project in production? Or are you managing the worker yourself?
Contributor
Author
There was a problem hiding this comment.
@sbc100 I used to use the proxy_to_worker flag, but have since moved to managing the worker myself, referencing the codes that I require from proxyWorker.js.
I am also in the process of moving my app to use pthreads with the -sPROXY_TO_PTHREAD flag. Which has the same issue.
Collaborator
There was a problem hiding this comment.
Do you have an open issue for this? Can we link to it from the PR description here?
Use parameterized attribute to run different variants of tests
Collaborator
|
Are you still interested in landing this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For repro-ing issues in glfw code
Discussion in issue: #19912