Skip to content

Implement wgpuCreateInstance #19762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2023
Merged

Implement wgpuCreateInstance #19762

merged 3 commits into from
Jun 30, 2023

Conversation

@beaufortfrancois
Copy link
Contributor

@beaufortfrancois beaufortfrancois commented Jun 30, 2023 •
edited
Loading

This PR updates wgpuCreateInstance() to always return 1 and changes wgpuInstanceCreateSurface and wgpuInstanceRequestAdapter to assert its value is 1. It also updates test/webgpu_basic_rendering.cpp test.

See #19349

Please review @kainino0x

kainino0x
kainino0x approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ nit

@kainino0x kainino0x changed the title Allow wgpuCreateInstance Implement wgpuCreateInstance Jun 30, 2023
@kainino0x kainino0x enabled auto-merge (squash) June 30, 2023 20:58
@kainino0x kainino0x merged commit 77cfd2d into emscripten-core:main Jun 30, 2023
@beaufortfrancois beaufortfrancois mentioned this pull request Jul 4, 2023
Merged
@beaufortfrancois beaufortfrancois mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kainino0x kainino0x kainino0x approved these changes

Assignees

No one assigned

Labels

webgpu

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@beaufortfrancois @kainino0x