Start using JS string template in JS code #19285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
use_string_templates
branch
from
2676a1a to
fd02cd9
Compare
Collaborator
Author
|
@brendandahl @kripken @juj what do you think about this direction? I think code-size-wise and performance-wise its mostly a wash, but maybe its win for maintainability/readability? |
Collaborator
Author
|
My motivation is partly that contributors tend to assume they can use this feature and we should probably be consistent about using it vs not using it. |
kripken
approved these changes
May 5, 2023
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
It is more readable I think, seems worthwhile.
Collaborator
|
This looks perfect! |
It looks like these have been implements for a very long time in all the engines: https://caniuse.com/template-literals I just chose of libraries to start with, and will continue with others if there are no objections.
sbc100
force-pushed
the
use_string_templates
branch
from
fd02cd9 to
6ce6de3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like these have been implements for a very long time in all the engines: https://caniuse.com/template-literals
I just chose of libraries to start with, and will continue with others if there are no objections.