Fix unescaped NUL character in JS #19231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to be the only such occurence, but I might have missed more. Fixes #19230.
kripken
approved these changes
Apr 21, 2023
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Interesting... I'm not sure what tool turns that into a literal 0, but sgtm to escape it. We could also just write "0" there I guess, which would be human-readable enough.
sbc100
reviewed
Apr 21, 2023
src/library_strings.js
Outdated
| * @param {number=} maxBytesToRead - An optional length that specifies the | ||
| * maximum number of bytes to read. You can omit this parameter to scan the | ||
| * string until the first \0 byte. If maxBytesToRead is passed, and the string | ||
| * string until the first \\0 byte. If maxBytesToRead is passed, and the string |
Collaborator
There was a problem hiding this comment.
How about null or NULL instead?
Collaborator
Author
There was a problem hiding this comment.
Yeah that works for me too, just wasn't sure if you'd be open to that. Or, as @kripken says, just "0 byte" also sounds good, I'll probably go with that.
Collaborator
Author
It's literally part of a JS string now and JS strings support escapes, so a string `'something \0 something`` gets nul character unescaped, just like it would be in string literals in most other langs. |
kripken
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be the only such occurence, but I might have missed more.
Fixes #19230.