fix library_websocket after pull request 19064 (len is undefined) #19190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Nice find! I got fooled by a JS var scoping rules! |
sbc100
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pull request #19064 variable "len" was moved to WEBSOCKET_DEBUG define, but it's used later in the function:
HEAPU32[(WS.socketEvent+8)>>2] = len;
So in case if we compile emscripten without "WEBSOCKET_DEBUG" define - value of "len" is undefined and being saved as 0 into structure on HEAP. Those websocket functionality with messages stops working.
This change was verified on our local project.