Test that JSPI works in chrome browser tests. #19026
Conversation
brendandahl
force-pushed
the
jspi-browser-test
branch
2 times, most recently
from
dd78012 to
e4c2c19
Compare
|
Could we enable one of the existing tests in JSPI mode perhaps? (say, |
brendandahl
force-pushed
the
jspi-browser-test
branch
from
e4c2c19 to
f47fc87
Compare
Good point. I originally thought I needed a more thorough test because test_async was passing without JSPI enabled, but it turns out my chrome profile already had JSPI enabled. I switched to a new profile now for tests now. |
brendandahl
force-pushed
the
jspi-browser-test
branch
from
f47fc87 to
4622d86
Compare
brendandahl
force-pushed
the
jspi-browser-test
branch
from
4622d86 to
c600b5b
Compare
| @parameterized({ | ||
| 'asyncify': (['-sASYNCIFY=1'],), | ||
| 'jspi': (['-sASYNCIFY=2', '-Wno-experimental'],), | ||
| }) |
There was a problem hiding this comment.
If we add more of these it might make sense to add a @also_with_jspi decorator or such, like we have for other stuff, but I'm not sure. Just a thought for later.
There was a problem hiding this comment.
Yeah, I was going to add this, but wasn't sure what happens when you have multiple -sASYNCIFY args i.e. the main test will have -sASYNCIFY=1, but the @also_with_jspi will add -sASYNCIFY=2. I'm guessing the last overwrites it?
There was a problem hiding this comment.
Yes, later -s flags should override.
3 participants
No description provided.