Fix __sig attributes that had the wrong length #18990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
fix_incorrect_sigs
branch
from
41ab987 to
99a1ba4
Compare
kripken
reviewed
Mar 17, 2023
src/library_sdl.js
Outdated
| SDL_GetWindowFlags__proxy: 'sync', | ||
| SDL_GetWindowFlags__sig: 'iii', | ||
| SDL_GetWindowFlags: function(x, y) { | ||
| SDL_GetWindowFlags__sig: 'ii', |
Member
There was a problem hiding this comment.
Suggested change
| SDL_GetWindowFlags__sig: 'ii', | |
| SDL_GetWindowFlags__sig: 'ip', |
The input is a pointer, I believe.
sbc100
force-pushed
the
fix_incorrect_sigs
branch
from
99a1ba4 to
c5bb3c9
Compare
This is the first set of __sig fixes that comes out of a larger fix for #18979, which will eventually remove all of these sigs from the JS code.
sbc100
force-pushed
the
fix_incorrect_sigs
branch
from
c5bb3c9 to
8f83400
Compare
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Mar 17, 2023
This is the first set of __sig fixes that comes out of a larger fix for emscripten-core#18979, which will eventually remove all of these sigs from the JS code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first set of __sig fixes that comes out of a larger fix for #18979, which will eventually remove all of these sigs from the JS code.