Rename emscripten_main_browser_thread_id to emscripten_main_runtime_thread_id. NFC #18872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
main_thread_id
branch
2 times, most recently
from
54ee4ff to
b904a79
Compare
…hread_id. NFC The better reflects that is actually being returned here. In fact, there may be no main browser thread at all, and we have never tracked the thread ID of the main browser thread, only the main runtime thread. Use a macro to continue to support the old name, but mark is as deprecated so folks will get a warning. Also, update the corresponding EM_CALLBACK_THREAD_CONTEXT_MAIN_BROWSER_THREAD macro.
sbc100
force-pushed
the
main_thread_id
branch
from
b904a79 to
571b003
Compare
tlively
approved these changes
Feb 28, 2023
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Mar 17, 2023
…hread_id. NFC (emscripten-core#18872) The better reflects that is actually being returned here. In fact, there may be no main browser thread at all, and we have never tracked the thread ID of the main browser thread, only the main runtime thread. Use a macro to continue to support the old name, but mark is as deprecated so folks will get a warning. Also, update the corresponding EM_CALLBACK_THREAD_CONTEXT_MAIN_BROWSER_THREAD macro.
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Mar 17, 2023
…hread_id. NFC (emscripten-core#18872) The better reflects that is actually being returned here. In fact, there may be no main browser thread at all, and we have never tracked the thread ID of the main browser thread, only the main runtime thread. Use a macro to continue to support the old name, but mark is as deprecated so folks will get a warning. Also, update the corresponding EM_CALLBACK_THREAD_CONTEXT_MAIN_BROWSER_THREAD macro.
toyobayashi
added a commit
to toyobayashi/emnapi
that referenced
this pull request
Mar 27, 2023
sbc100
added a commit
that referenced
this pull request
Jun 22, 2023
- There was a partial renaming in #18872 which broken the build of this test. - The passing of 0 instead of EMSCRIPTEN_EVENT_TARGET_WINDOW was generating a warnings that null is not allowed for argument zero. - No need to use (void*) when we can just use pthread_t.
sbc100
added a commit
that referenced
this pull request
Jun 22, 2023
- There was a partial renaming in #18872 which broken the build of this test. - The passing of 0 instead of EMSCRIPTEN_EVENT_TARGET_WINDOW was generating a warnings that null is not allowed for argument zero. - No need to use (void*) when we can just use pthread_t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The better reflects that is actually being returned here. In fact, there may be no main browser thread at all, and we have never tracked the thread ID of the main browser thread, only the main runtime thread.
Use a macro to continue to support the old name, but mark is as deprecated so folks will get a warning.