Set CMAKE_NM in CMake toolchain file #18842
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
CMAKE_NMin the CMake toolchain file.We ran into some issues where the system's
nmwas used instead ofemnm, and we traced it back to the Emscripten CMake toolchain file not settingCMAKE_NM.We fixed this locally by setting
CMAKE_NMafter including the Emscripten toolchain CMake file, but figured it's better to push a fix upstream.