Skip to content

Conversation

@coderedart
Copy link
Contributor

@coderedart coderedart commented Feb 23, 2023

updated glfw header to 3.3.8 @ https://raw.githubusercontent.com/glfw/glfw/3.3.8/include/GLFW/glfw3.h

adds functions related to scale(dpi).

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for working on this.

Can you add something to the ChangeLog about this?

@coderedart
Copy link
Contributor Author

I think every commit will be the last one and try to name it upgrade glfw to 3.3 :D

@sbc100
Copy link
Collaborator

sbc100 commented Feb 24, 2023

I think every commit will be the last one and try to name it upgrade glfw to 3.3 :D

I guess my question is which of the 3.3 releases did you use?

There is the base 3.3 release:

https://github.com/glfw/glfw/blob/3.3/include/GLFW/glfw3.h

And then there are several more:

https://github.com/glfw/glfw/tags

Or did you use the on that is on master as of right now?

Maybe we should choose the latest tag which is 3.3.8 from July of last year?

@coderedart
Copy link
Contributor Author

@sbc100 sorry for the late reply.

I used the header from 3.3.8 which is the latest stable release tag on github.
the master branch is at version 3.4

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! lgtm

@sbc100 sbc100 enabled auto-merge (squash) February 25, 2023 00:00
@sbc100 sbc100 merged commit 7cd514d into emscripten-core:main Feb 25, 2023
@coderedart coderedart deleted the glfw_upgrade branch February 25, 2023 04:58
impact-maker pushed a commit to impact-maker/emscripten that referenced this pull request Mar 17, 2023
impact-maker pushed a commit to impact-maker/emscripten that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants