-
Notifications
You must be signed in to change notification settings - Fork 3.5k
upgrade glfw to 3.3 #18826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade glfw to 3.3 #18826
Conversation
sbc100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for working on this.
Can you add something to the ChangeLog about this?
|
I think every commit will be the last one and try to name it |
I guess my question is which of the 3.3 releases did you use? There is the base 3.3 release: https://github.com/glfw/glfw/blob/3.3/include/GLFW/glfw3.h And then there are several more: https://github.com/glfw/glfw/tags Or did you use the on that is on master as of right now? Maybe we should choose the latest tag which is 3.3.8 from July of last year? |
|
@sbc100 sorry for the late reply. I used the header from 3.3.8 which is the latest stable release tag on github. |
sbc100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! lgtm
updated glfw header to 3.3.8 @ https://raw.githubusercontent.com/glfw/glfw/3.3.8/include/GLFW/glfw3.h adds functions related to scale(dpi).
updated glfw header to 3.3.8 @ https://raw.githubusercontent.com/glfw/glfw/3.3.8/include/GLFW/glfw3.h adds functions related to scale(dpi).
updated glfw header to 3.3.8 @ https://raw.githubusercontent.com/glfw/glfw/3.3.8/include/GLFW/glfw3.h
adds functions related to scale(dpi).