Skip to content

When running tests with --save-dir use the local out/test directory #18562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2023
Merged

When running tests with --save-dir use the local out/test directory #18562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/source/docs/getting_started/test-suite.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ emits debug output and intermediate files (the files go in


You can also specify ``--save-dir`` to save the temporary directory that the
test runner uses into **/tmp/emscripten_test/**. This is a test suite-specific
test runner uses into **/out/test/**. This is a test suite-specific
feature, and is useful for inspecting test outputs as well as temporary files
generated by the test. By default, the temporary directory will be cleaned
between each test run, but you can add ``--no-clean`` to avoid this.
Expand Down
2 changes: 1 addition & 1 deletion test/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ def setUp(self):
self.temp_files_before_run.append(os.path.normpath(os.path.join(root, filename)))

if EMTEST_SAVE_DIR:
self.working_dir = os.path.join(self.temp_dir, 'emscripten_test')
self.working_dir = path_from_root('out/test')
if os.path.exists(self.working_dir):
if EMTEST_SAVE_DIR == 2:
print('Not clearing existing test directory')
Expand Down