Use null at the end of {{{ }}} code blocks that are side-effect only. NFC
#18324
+14
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y. NFC This, IMHO, is more reasonable than creating an IIFE than returns null.
sbc100
force-pushed
the
runtime_support_functions
branch
from
9896c1b to
7396aa4
Compare
kripken
approved these changes
Dec 6, 2022
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Nice, I didn't know eval worked that way...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This, IMHO, is more reasonable than creating an IIFE than returns null.