Add SDL_config file for emscripten #17487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
add_sdl_config
branch
2 times, most recently
from
9ded74d to
08a70a4
Compare
dschuff
reviewed
Jul 21, 2022
dschuff
reviewed
Jul 21, 2022
Collaborator
Author
|
Removed a bunch of defines. |
I noticed that we lacked such a thing while working on #17475. It turns out that system header are technically allowed to redefine macros without generating a warning, but when I made the SDL header tree into a normal `-I` path I noticed that `M_PI` was being duplicately defined because we were not defining `HAVE_M_PI`. This list of defines is taked from `SDL_config_iphoneos.h` and a visual inspection seems to confirm that we do indeed support all the specified features.
dschuff
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we lacked such a thing while working on #17475. It turns
out that system header are technically allowed to redefine macros
without generating a warning, but when I made the SDL header tree into a
normal
-Ipath I noticed thatM_PIwas being duplicately definedbecause we were not defining
HAVE_M_PI.This list of defines is taked from
SDL_config_iphoneos.hand a visualinspection seems to confirm that we do indeed support all the specified
features.
See https://gcc.gnu.org/onlinedocs/cpp/System-Headers.html:
"Macros defined in a system header are immune to a few warnings wherever they are expanded. This immunity is granted on an ad-hoc basis, when we find that a warning generates lots of false positives because of code in macros defined in system headers."