Skip to content

Pass -sSTRICT when building ports and system libraries. NFC #17480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Pass -sSTRICT when building ports and system libraries. NFC #17480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tools/ports/cocos2d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ def get(ports, settings, shared):
'cocos2d', 'https://github.com/emscripten-ports/Cocos2d/archive/' + TAG + '.zip', 'Cocos2d-' + TAG, sha512hash=HASH)

def create(final):
logging.info('building port: cocos2d v3')
logging.warn('cocos2d: library is experimental, do not expect that it will work out of the box')

cocos2d_src = os.path.join(ports.get_dir(), 'cocos2d')
Expand Down Expand Up @@ -51,6 +50,9 @@ def create(final):
'-DCC_KEYBOARD_SUPPORT',
'-DGL_ES=1',
'-DNDEBUG', # '-DCOCOS2D_DEBUG=1' 1 - error/warn, 2 - verbose
# Cocos2d source code hasn't switched to __EMSCRIPTEN__.
# See https://github.com/emscripten-ports/Cocos2d/pull/3
'-DEMSCRIPTEN',
'-DCP_USE_DOUBLES=0',
'-O2',
'-sUSE_ZLIB=1',
Expand Down
2 changes: 1 addition & 1 deletion tools/system_libs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def glob_in_path(path, glob_pattern, excludes=()):
def get_base_cflags(force_object_files=False):
# Always build system libraries with debug information. Non-debug builds
# will ignore this at link time because we link with `-strip-debug`.
flags = ['-g']
flags = ['-g', '-sSTRICT']
if settings.LTO and not force_object_files:
flags += ['-flto=' + settings.LTO]
if settings.RELOCATABLE:
Expand Down