Fix unexpected runtime exit with EXIT_RUNTIMEwhile calling glfwSetWindowSize
#17376
Conversation
| #if USE_GLFW == 3 | ||
| {{{ makeDynCall('viii', 'GLFW.active.windowSizeFunc') }}}(GLFW.active.id, GLFW.active.width, GLFW.active.height); | ||
| #endif | ||
| }); |
There was a problem hiding this comment.
The idea is that if the runtime is no longer active we do want to exit here. See the keepRuntimeAlive function.. for some reason it must b returning false in your use case, and its probably worth looking into why.
tests/glfw3.c
Outdated
| glfwGetWindowPos(window, &x, &y); // stub | ||
| glfwGetWindowSize(window, &w, &h); | ||
| assert(w == 640 && h == 480); | ||
| assert(exited == 0); |
There was a problem hiding this comment.
Does this assert fire if you won't include your patch?
There was a problem hiding this comment.
this assert is just in the incorrect line. thanks.
There was a problem hiding this comment.
And it fires, without this patch? (i.e. if I add this assert locally I will see the test fail?)
There was a problem hiding this comment.
This assertion fires with -sEXIT_RUNTIME=1.
(I've used --emrun, which implies -sEXIT_RUNTIME=1)
nokotan
changed the title
EXIT_RUNTIMEwhile calling glfwSetWindowSize
|
I think I found the root of the issue and will upload a patch shortly. Thanks for figuring out where this issue was showing up! |
See #17376 for the original report inspiration for the modified test.
See #17376 for the original report inspiration for the modified test.
|
I think #17438 should fix this issue. |
See #17376 for the original report inspiration for the modified test.
See #17376 for the original report inspiration for the modified test.
2 participants
When called
glfwSetWindowSize, emscripten runtime will exit unintentionally.