Replace uses of for..of loops in generated code #16783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These uses had unintentionally slipped in. We have meant to avoid for..of loops so far because very old browsers do not support them.
|
Sadly we still don't allow a lot ES6 constructs because I've not figured out how to include the closure polyfill code on older browser. I hope we can get there one day but we are not there yet. |
sbc100
approved these changes
Apr 22, 2022
tlively
added a commit
that referenced
this pull request
Apr 27, 2022
These uses had unintentionally slipped in. We have meant to avoid for..of loops so far because very old browsers do not support them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These uses had unintentionally slipped in. We have meant to avoid for..of loops
so far because very old browsers do not support them.