Avoid space after -s when for command line settings. NFC
#16025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Jan 14, 2022
We still have a test for the form that does include the space but we want to encourage folks to use the one without the space. Its more concise, and less prone to issues such as the once where cmake re-orders link flags in some cases.
sbc100
added a commit
that referenced
this pull request
Mar 13, 2022
sbc100
added a commit
that referenced
this pull request
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still have a test for the form that does include the space
but we want to encourage folks to use the one without the space.
Its more concise, and less prone to issues such as the once where
cmake re-orders link flags in some cases.