Modernize and run eslint on tools/acorn-optimizer.js. NFC #15836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
acorn_optimizer
branch
3 times, most recently
from
03c3c2d to
34ea81d
Compare
aheejin
reviewed
Dec 22, 2021
| // Check for an array of children. | ||
| if (Array.isArray(child)) { | ||
| child.forEach(maybeChild); | ||
| if (Object.prototype.hasOwnProperty.call(node, key)) { |
Member
There was a problem hiding this comment.
Does lint auto-change code in LHS to RHS by adding these lines? (Not very familiar with eslint myself)
Collaborator
Author
There was a problem hiding this comment.
No, the linter complains that when you iterate through an object with for in you need to include an inner check for hasOwnProperty:
Here is the rule: https://eslint.org/docs/rules/guard-for-in
| // analysis here. | ||
|
|
||
| function JSDCE(ast, aggressive) { | ||
| function runJSDCE(ast, aggressive) { |
Collaborator
Author
There was a problem hiding this comment.
There is a rule that says that any function that starts with a Capital letter must be a constructor function (and this isn't one).
sbc100
force-pushed
the
acorn_optimizer
branch
2 times, most recently
from
7daef3c to
4a41a5c
Compare
sbc100
force-pushed
the
acorn_optimizer
branch
from
4a41a5c to
276d4bc
Compare
aheejin
approved these changes
Dec 22, 2021
Member
aheejin
left a comment
aheejin
left a comment
There was a problem hiding this comment.
Didn't check each change in detail, but LGTM if this is what eslint tells to do. By the way, does eslint fix things by itself, or we need fix it manually? How can I run eslint on a specific js file based on our configuration?
Collaborator
Author
|
Yes, eslint can fix some/all of the issue it finds automatically, but I have no yet chosen to use that feature, preferring to do it myself so that I internalize the rules and can understand the changes being made. So this change, for example, was fully hand rolled. To run eslint you can just run |
sbc100
added a commit
that referenced
this pull request
Dec 23, 2021
This change does not effect the JS that we output, only the the internal JS tooling. This is a followup to #15836 which did this cleanup just for a single file. The long list of exclusions in `.eslintrc.yml` is because these files are part of the JS library code which we ship and we a lot of that cannot be run though the lint tool because it uses our speciall pre-processing techniques.
sbc100
added a commit
that referenced
this pull request
Dec 23, 2021
sbc100
added a commit
that referenced
this pull request
Dec 23, 2021
This change does not effect the JS that we output, only the the internal JS tooling. This is a followup to #15836 which did this cleanup just for a single file. The long list of exclusions in `.eslintrc.yml` is because these files are part of the JS library code which we ship and we a lot of that cannot be run though the lint tool because it uses our speciall pre-processing techniques.
sbc100
added a commit
that referenced
this pull request
Dec 23, 2021
sbc100
added a commit
that referenced
this pull request
Dec 23, 2021
sbc100
added a commit
that referenced
this pull request
Dec 26, 2021
sbc100
added a commit
that referenced
this pull request
Dec 26, 2021
This change does not effect the JS that we output, only the the internal JS tooling. This is a followup to #15836 which did this cleanup just for a single file. The long list of exclusions in `.eslintrc.yml` is because these files are part of the JS library code which we ship and we a lot of that cannot be run though the lint tool because it uses our speciall pre-processing techniques.
sbc100
added a commit
that referenced
this pull request
Dec 26, 2021
This change does not effect the JS that we output, only the the internal JS tooling. This is a followup to #15836 which did this cleanup just for a single file. The long list of exclusions in `.eslintrc.yml` is because these files are part of the JS library code which we ship and we a lot of that cannot be run though the lint tool because it uses our speciall pre-processing techniques.
sbc100
added a commit
that referenced
this pull request
Dec 27, 2021
This change does not effect the JS that we output, only the the internal JS tooling. This is a followup to #15836 which did this cleanup just for a single file. The long list of exclusions in `.eslintrc.yml` is because these files are part of the JS library code which we ship and we a lot of that cannot be run though the lint tool because it uses our speciall pre-processing techniques.
sbc100
added a commit
that referenced
this pull request
Dec 27, 2021
sbc100
added a commit
that referenced
this pull request
Dec 28, 2021
This change does not effect the JS that we output, only the the internal JS tooling. This is a followup to #15836 which did this cleanup just for a single file. The long list of exclusions in `.eslintrc.yml` is because these files are part of the JS library code which we ship and we a lot of that cannot be run though the lint tool because it uses our speciall pre-processing techniques.
sbc100
added a commit
that referenced
this pull request
Dec 29, 2021
This change does not effect the JS that we output, only the the internal JS tooling. This is a followup to #15836 which did this cleanup just for a single file. The long list of exclusions in `.eslintrc.yml` is because these files are part of the JS library code which we ship and we a lot of that cannot be run though the lint tool because it uses our speciall pre-processing techniques.
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
…-core#15845) This change does not effect the JS that we output, only the the internal JS tooling. This is a followup to emscripten-core#15836 which did this cleanup just for a single file. The long list of exclusions in `.eslintrc.yml` is because these files are part of the JS library code which we ship and we a lot of that cannot be run though the lint tool because it uses our speciall pre-processing techniques.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.