Enable testing for __sync_fetch_and_nand. NFC #15620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrary to the comments there these atomics ops seem to work fine these days. The only exception is that __sync_fetch_and_nand doesn't work under wasm2js due to a current binaryen limittion.
juj
approved these changes
Nov 24, 2021
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
Contrary to the comments there these atomics ops seem to work fine these days. The only exception is that __sync_fetch_and_nand doesn't work under wasm2js due to a current binaryen limitation. See WebAssembly/binaryen#4358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to the comments there these atomics ops seem to work
fine these days.
The only exception is that __sync_fetch_and_nand doesn't work
under wasm2js due to a current binaryen limitation.
See WebAssembly/binaryen#4358