Avoid setting EXPORTED_FUNCTIONS with MAIN_MODULE=1 #15257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting is meaningless with MAIN_MODULE=1 or SIDE_MODULE=1. Hopefully this will be a warning soon: #10075 Also avoid using C++ in some tests that don't need it.
sbc100
force-pushed
the
main_module_exported_functions
branch
from
3bd268e to
3bc7024
Compare
kripken
approved these changes
Oct 8, 2021
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Perhaps these could be useful some day if we want to switch the tests to mode 2?
But I agree we can remove them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting is meaningless with MAIN_MODULE=1 or SIDE_MODULE=1.
Hopefully this will be a warning soon:
#10075
Also avoid using C++ in some tests that don't need it.