Skip to content

Temporarily disable metadce and code size tests #13789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/test_other.py
Original file line number Diff line number Diff line change
Expand Up @@ -6813,6 +6813,8 @@ def assertFileContents(self, filename, contents):

def run_metadce_test(self, filename, args, expected_exists, expected_not_exists, expected_size,
check_sent=True, check_imports=True, check_exports=True, check_funcs=True):
return self.skipTest('let https://github.com/WebAssembly/binaryen/pull/3730 roll in')

size_slack = 0.05

# in -Os, -Oz, we remove imports wasm doesn't need
Expand Down Expand Up @@ -8436,6 +8438,7 @@ def test(args, closure, opt):
'hello_webgl2_wasm': ('hello_webgl2', False),
'hello_webgl2_wasm2js': ('hello_webgl2', True),
})
@unittest.skip('let https://github.com/WebAssembly/binaryen/pull/3730 roll in')
def test_minimal_runtime_code_size(self, test_name, js, compare_js_output=False):
smallest_code_size_args = ['-s', 'MINIMAL_RUNTIME=2',
'-s', 'ENVIRONMENT=web',
Expand Down