Fix WebGL emscripten_webgl_get_context_attributes() proxying #11356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reenCanvas and Offscreen Framebuffer builds. Autogenerate the simplest pattern of proxying mechanism to clean up the code to avoid repeating the proxy boilerplate each time.
kripken
reviewed
Jun 5, 2020
| delete funcs[i + '__proxy']; | ||
| var funcArgs = listOfNFunctionArgs(funcs[i]); | ||
| var funcArgsString = funcArgs.join(','); | ||
| var funcBody = `return GL.contexts[p0] ? _${i}_calling_thread(${funcArgsString}) : _${i}_main_thread(${funcArgsString});`; |
Member
There was a problem hiding this comment.
the comment earlier says this may need to run on the same thread, the main thread, or another pthread. How is the case of another pthread handled? IIUC this line handles the other two.
Collaborator
Author
There was a problem hiding this comment.
That is the TODO in this block. It is an existing limitation that has never worked. For a few functions (canvas size setting and getting) I have manually written the pthread->pthread proxying path, it is considerably more complex.
kripken
approved these changes
Jun 8, 2020
| delete funcs[i + '__proxy']; | ||
| var funcArgs = listOfNFunctionArgs(funcs[i]); | ||
| var funcArgsString = funcArgs.join(','); | ||
| var funcBody = `return GL.contexts[p0] ? _${i}_calling_thread(${funcArgsString}) : _${i}_main_thread(${funcArgsString});`; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix WebGL emscripten_webgl_get_context_attributes() proxying in OffscreenCanvas and Offscreen Framebuffer builds. Autogenerate the simplest pattern of proxying mechanism to clean up the code to avoid repeating the proxy boilerplate each time.