-O0 Hello world working with MINIMAL_RUNTIME. #10056
Conversation
| for e in exports: | ||
| receiving.append('var %(mangled)s = Module["%(mangled)s"] = asm["%(e)s"];' % {'mangled': asmjs_mangle(e), 'e': e}) | ||
| if shared.Settings.DECLARE_ASM_MODULE_EXPORTS: | ||
| if shared.Settings.WASM and shared.Settings.MINIMAL_RUNTIME: |
There was a problem hiding this comment.
why does wasm2js output differ from wasm output here? in general in the wasm backend the js/wasm paths are much more similar than in fastcomp (wasm2js literally polyfills the WebAssembly APIs, and everything should be identical except for that), so I was hoping we would not have differences here.
There was a problem hiding this comment.
I don't know yet. I have not yet tried against wasm2js. I just put this like this to follow the fastcomp route, and did not go too far making modifications to keep the amount to review small for each PR.
juj
force-pushed
the
wasm_backend_minimal_runtime_hello_world
branch
from
2886b50 to
5f6e9c2
Compare
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Fair enough, lgtm with that settings_internal.js comment addressed.
|
Check - updated to address review and pass tests, I'll land this once tests come through, and proceed to next set of features. |
juj
force-pushed
the
wasm_backend_minimal_runtime_hello_world
branch
from
f42831e to
0d5720b
Compare
| if (array.length > 0) { | ||
| return "['" + array.join("','") + "']"; | ||
| } else { | ||
| return []; |
There was a problem hiding this comment.
shouldn't this be a string too?
There was a problem hiding this comment.
That would certainly help the code to work..
* -O0 Hello world working with MINIMAL_RUNTIME.
* -O0 Hello world working with MINIMAL_RUNTIME.
2 participants
This makes a first step towards getting MINIMAL_RUNTIME working with wasm backend.